git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 0/3] git-p4: fix handling of multi-word P4EDITOR

From
Luke Diamand <luke@diamand.org>
Date
May 19, 2015, 22:23 UTC
Message-ID
<1432074198-13806-1-git-send-email-luke@diamand.org>
In-Reply-To
<xmqqa8x0a7wq.fsf@gitster.dls.corp.google.com>

Junio noticed that my new test was using touch, which is a bit racetastic because git-p4 wants P4EDITOR to spend at least one second editing the submit template or it will fail.

This updates the test to use test-chmtime, and also fixes the other git-p4 tests in the same way.

Luke Diamand (3):
  git-p4: add failing test for P4EDITOR handling
  git-p4: fix handling of multi-word P4EDITOR
  git-p4: tests: use test-chmtime in place of touch
 git-p4.py                          |  2 +-
 t/t9803-git-p4-shell-metachars.sh  |  4 ++--
 t/t9805-git-p4-skip-submit-edit.sh |  4 ++--
 t/t9813-git-p4-preserve-users.sh   |  7 ++++---
 t/t9820-git-p4-editor-handling.sh  | 38 ++++++++++++++++++++++++++++++++++++++
 5 files changed, 47 insertions(+), 8 deletions(-)
 create mode 100755 t/t9820-git-p4-editor-handling.sh
-- 
2.4.1.502.gb11c5ab
Previous: Junio C HamanoNext: Luke Diamand
Message 3 of 11 in “git-p4: test t9820-git-p4-editor-handling.sh failing”
  1. Luke DiamandMay 19, 2015
  2. Junio C HamanoMay 19, 2015
  3. 0/3 git-p4: fix handling of multi-word P4EDITORLuke Diamand, May 19, 2015
  4. 1/3 git-p4: add failing test for P4EDITOR handlingLuke Diamand, May 19, 2015
  5. Junio C HamanoMay 20, 2015
  6. Junio C HamanoMay 20, 2015
  7. Luke DiamandMay 20, 2015
  8. 2/3 git-p4: fix handling of multi-word P4EDITORLuke Diamand, May 19, 2015
  9. 3/3 git-p4: tests: use test-chmtime in place of touchLuke Diamand, May 19, 2015
  10. Luke DiamandMay 19, 2015
  11. Junio C HamanoMay 24, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.