git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] completion: Add sequencer function

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 1, 2015, 14:38 UTC
Message-ID
<xmqq6177a3zk.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150530210103.Horde.YoJthfdQJy5oq9wT_oOl3Q1@webmail.informatik.kit.edu>
SZEDER Gábor <szeder@ira.uka.de> writes:
Show 8 quoted lines
> I don't see the benefits of this change.  This patch adds more than  
> twice as many lines as it removes, and patch 2/2 adds 8 new lines  
> although it could get away with only 5 without this function.  To  
> offer sequencer options we currently go through a single if statement,  
> with this patch we'd go through a case statement, an if statement and  
> finally an &&.
>
> Gábor

Perhaps, especially given that I'd imagine we won't be adding 47 new commands that drive the sequencer in the near future ;-)

I presume that you are OK with Thomas's original version, then?
Previous: SZEDER GáborNext: SZEDER Gábor
Message 8 of 10 in “completion: suggest sequencer commands for revert”
  1. completion: suggest sequencer commands for revertThomas Braun, May 25, 2015
  2. Junio C HamanoMay 29, 2015
  3. Ramkumar RamachandraMay 29, 2015
  4. 0/2 completion: sequencer commandsThomas Braun, May 30, 2015
  5. 2/2 completion: suggest sequencer commands for revertThomas Braun, May 30, 2015
  6. 1/2 completion: Add sequencer functionThomas Braun, May 30, 2015
  7. SZEDER GáborMay 30, 2015
  8. Junio C HamanoJun 1, 2015
  9. SZEDER GáborJun 1, 2015
  10. 1/2 completion: Add sequencer functionThomas Braun, May 30, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.