Re: [PATCH v2 1/2] completion: Add sequencer function

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Jun 1, 2015, 15:06 UTC
Message-ID: <20150601170603.Horde.iiRpDlRNsOoCFFaHVSBOwg1@webmail.informatik.kit.edu>
In-Reply-To: <xmqq6177a3zk.fsf@gitster.dls.corp.google.com>

Quoting Junio C Hamano <gitster@pobox.com>:

Show 15 quoted lines

> SZEDER Gábor <szeder@ira.uka.de> writes:
>
>> I don't see the benefits of this change.  This patch adds more than
>> twice as many lines as it removes, and patch 2/2 adds 8 new lines
>> although it could get away with only 5 without this function.  To
>> offer sequencer options we currently go through a single if statement,
>> with this patch we'd go through a case statement, an if statement and
>> finally an &&.
>>
>> Gábor
>
> Perhaps, especially given that I'd imagine we won't be adding 47 new
> commands that drive the sequencer in the near future ;-)
>
> I presume that you are OK with Thomas's original version, then?

Yes, definitely.

It's a shame all these sequencing commands have different sets of sequencer options. Perhaps something to clean up for, say, v3.0 :)

Gábor