Re: [PATCH v3 1/7] t0027: Add tests for get_stream_filter()

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2016, 17:59 UTC
Message-ID: <xmqq60xz9j79.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1454688800-20714-1-git-send-email-tboegi@web.de>

tboegi@web.de writes:

> From: Torsten Bögershausen <tboegi@web.de>
> Subject: Re: [PATCH v3 1/7] t0027: Add tests for get_stream_filter()

s/: Add/: add/ (no need to resend this)

Show 16 quoted lines

> When a filter is configured, a different code-path is used in convert.c
> and entry.c via get_stream_filter(), but there are no test cases yet.
>
> Add tests for the filter API by configuring the ident filter.
> The result of the SHA1 conversion is not checked, this is already
> done in other TC.
>
> Add a parameter to checkout_files() in t0027.
> While changing the signature, add another parameter for the eol= attribute.
> This is currently unused, tests for e.g.
> "* text=auto eol=lf" will be added in a separate commit.
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
> Changes since v2:
> 1/7 t0027 uses ident instead of i (the empty "" is still there)

Thanks, much easier to understand with that spelled out.

And making "" a noop makes sense given the way this helper is called (i.e. it is fed "$ident" and "$attr" quoted in dq, and they could become empty string--it is not worth doing ${ident:+"$ident"} there).