Re: [PATCH 2/2] describe: add support for multiple match patterns

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 8, 2016, 00:20 UTC
Message-ID: <xmqq60mvuv8v.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+P7+xrPivwMzGhzKxu30jns+YvSQGXBKUc4JDmfbenTy27tZg@mail.gmail.com>

Jacob Keller <jacob.keller@gmail.com> writes:

Show 5 quoted lines

> Basically, this started as a script to try each pattern in sequence,
> but this is slow, cumbersome and easy to mess up.
>
> You're suggesting just add a single second pattern that we will do
> matches and discard any tag that matches that first?

I am not suggesting anything. I was just trying to see how well what was designed and implemented supports the use case that motivated the feature. Think of it as a sanity check and review of the design.

> I think I can implement that pretty easily, and it should have simpler
> semantics. We can discard first, and then match what remains easily.

I actually think "multiple" and "negative" are orthogonal and both are good things. If we are enhancing the filtering by refname patterns to allow multiple patterns (i.e. your patch), that is good, and it would be ideal if we can also have support for negative ones.