Re: [PATCH 2/2] describe: add support for multiple match patterns

From: Jacob Keller <jacob.keller@gmail.com>
Date: Dec 8, 2016, 01:04 UTC
Message-ID: <CA+P7+xrWUS9BuwoOjGv+VtC5gR9vWrf7ANnks87fqvoDst9dAg@mail.gmail.com>
In-Reply-To: <xmqq60mvuv8v.fsf@gitster.mtv.corp.google.com>

On Wed, Dec 7, 2016 at 4:20 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Jacob Keller <jacob.keller@gmail.com> writes:
>
>> Basically, this started as a script to try each pattern in sequence,
>> but this is slow, cumbersome and easy to mess up.
>>
>> You're suggesting just add a single second pattern that we will do
>> matches and discard any tag that matches that first?
>
> I am not suggesting anything. I was just trying to see how well what
> was designed and implemented supports the use case that motivated
> the feature. Think of it as a sanity check and review of the design.
>

Makes sense.

Show 7 quoted lines

>> I think I can implement that pretty easily, and it should have simpler
>> semantics. We can discard first, and then match what remains easily.
>
> I actually think "multiple" and "negative" are orthogonal and both
> are good things.  If we are enhancing the filtering by refname
> patterns to allow multiple patterns (i.e. your patch), that is good,
> and it would be ideal if we can also have support for negative ones.

I can add support for negative matches pretty easily. I personally don't see the value of "logical and" filters, ie to match only tags that match all the given filters, though that does allow some other forms of expression.

I do like the idea of negative filters, and I'll go ahead and work on adding that as another extension.

Thanks, Jake