Re: [PATCH 1/5] t1700-split-index: drop unnecessary 'grep'

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 6, 2018, 21:24 UTC
Message-ID: <xmqq5zziz5du.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180906024810.8074-2-szeder.dev@gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 10 quoted lines

> The test 'disable split index' in 't1700-split-index.sh' runs the
> following pipeline:
>
>   cmd | grep <pattern> | sed s///
>
> Drop that 'grep' from the pipeline, and let 'sed' take over its
> duties.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---

Obviously good ;-)  Thanks.

Show 16 quoted lines

>  t/t1700-split-index.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh
> index b3b4d83eaf..be22398a85 100755
> --- a/t/t1700-split-index.sh
> +++ b/t/t1700-split-index.sh
> @@ -57,7 +57,7 @@ test_expect_success 'disable split index' '
>  	EOF
>  	test_cmp ls-files.expect ls-files.actual &&
>  
> -	BASE=$(test-tool dump-split-index .git/index | grep "^own" | sed "s/own/base/") &&
> +	BASE=$(test-tool dump-split-index .git/index | sed -n "s/^own/base/p") &&
>  	test-tool dump-split-index .git/index | sed "/^own/d" >actual &&
>  	cat >expect <<-EOF &&
>  	not a split index