Re: [PATCH] MyFirstObjectWalk: remove unnecessary conditional statement

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 30, 2020, 18:26 UTC
Message-ID: <xmqq5zel8zsx.fsf@gitster.c.googlers.com>
In-Reply-To: <20200330180742.GB37946@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 16 quoted lines

> On Sat, Mar 28, 2020 at 03:19:13PM +0000, Johannes Schindelin via GitGitGadget wrote:
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>> 
>> In the given example, `commit` cannot be `NULL` (because this is the
>> loop condition: if it was `NULL`, the loop body would not be entered at
>> all). It took this developer a moment or two to see that this is
>> therefore dead code.
>
> Nice catch. Thanks.
>
>> 
>> Let's remove it, to avoid puzzling future readers.
>> 
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Reviewed-by: Emily Shaffer <emilyshaffer@google.com>

Thanks, both.