threads / patch / 53123

patchMyFirstObjectWalk: remove unnecessary conditional statement

Subject: [PATCH] MyFirstObjectWalk: remove unnecessary conditional statement

## tl;dr

3 messages between Mar 28, 2020 and Mar 30, 2020. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Johannes Schindelin via GitGitGadget· Mar 28, 2020, 15:19 UTC · lore

From: Johannes Schindelin <johannes.schindelin@gmx.de>

In the given example, `commit` cannot be `NULL` (because this is the loop condition: if it was `NULL`, the loop body would not be entered at all). It took this developer a moment or two to see that this is therefore dead code.

Let's remove it, to avoid puzzling future readers.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    MyFirstObjectWalk: remove unnecessary conditional statement
    
    Our introductory documentation made me scratch my head because our
    example contains dead code. I'd like to remove it lest we confuse future
    contributors.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-589%2Fdscho%2Fgit-walken-head-scratcher-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-589/dscho/git-walken-head-scratcher-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/589

 Documentation/MyFirstObjectWalk.txt | 3 ---
 1 file changed, 3 deletions(-)

Show changes to Documentation/MyFirstObjectWalk.txt +0 −3

diff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt
index aa828dfdc44..c3f2d1a831e 100644
--- a/Documentation/MyFirstObjectWalk.txt
+++ b/Documentation/MyFirstObjectWalk.txt
@@ -357,9 +357,6 @@ static void walken_commit_walk(struct rev_info *rev)
 	...
 
 	while ((commit = get_revision(rev))) {
-		if (!commit)
-			continue;
-
 		strbuf_reset(&prettybuf);
 		pp_commit_easy(CMIT_FMT_ONELINE, commit, &prettybuf);
 		puts(prettybuf.buf);

base-commit: 3bab5d56259722843359702bc27111475437ad2a

-- 
gitgitgadget

Emily Shaffer· Mar 30, 2020, 18:07 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH] MyFirstObjectWalk: remove unnecessary conditional statement

On Sat, Mar 28, 2020 at 03:19:13PM +0000, Johannes Schindelin via GitGitGadget wrote:

Show 6 quoted lines

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> In the given example, `commit` cannot be `NULL` (because this is the
> loop condition: if it was `NULL`, the loop body would not be entered at
> all). It took this developer a moment or two to see that this is
> therefore dead code.

Nice catch. Thanks.

> 
> Let's remove it, to avoid puzzling future readers.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Reviewed-by: Emily Shaffer <emilyshaffer@google.com>

Show 32 quoted lines

> ---
>     MyFirstObjectWalk: remove unnecessary conditional statement
>     
>     Our introductory documentation made me scratch my head because our
>     example contains dead code. I'd like to remove it lest we confuse future
>     contributors.
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-589%2Fdscho%2Fgit-walken-head-scratcher-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-589/dscho/git-walken-head-scratcher-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/589
> 
>  Documentation/MyFirstObjectWalk.txt | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt
> index aa828dfdc44..c3f2d1a831e 100644
> --- a/Documentation/MyFirstObjectWalk.txt
> +++ b/Documentation/MyFirstObjectWalk.txt
> @@ -357,9 +357,6 @@ static void walken_commit_walk(struct rev_info *rev)
>  	...
>  
>  	while ((commit = get_revision(rev))) {
> -		if (!commit)
> -			continue;
> -
>  		strbuf_reset(&prettybuf);
>  		pp_commit_easy(CMIT_FMT_ONELINE, commit, &prettybuf);
>  		puts(prettybuf.buf);
> 
> base-commit: 3bab5d56259722843359702bc27111475437ad2a
> -- 
> gitgitgadget

Junio C Hamano· Mar 30, 2020, 18:26 UTC · re: Emily Shaffer · lore

Re: [PATCH] MyFirstObjectWalk: remove unnecessary conditional statement

Emily Shaffer <emilyshaffer@google.com> writes:

Show 16 quoted lines

> On Sat, Mar 28, 2020 at 03:19:13PM +0000, Johannes Schindelin via GitGitGadget wrote:
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>> 
>> In the given example, `commit` cannot be `NULL` (because this is the
>> loop condition: if it was `NULL`, the loop body would not be entered at
>> all). It took this developer a moment or two to see that this is
>> therefore dead code.
>
> Nice catch. Thanks.
>
>> 
>> Let's remove it, to avoid puzzling future readers.
>> 
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Reviewed-by: Emily Shaffer <emilyshaffer@google.com>

Thanks, both.