git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] auto-gc: pass --quiet down from am, commit, merge and rebase

From
Junio C Hamano <gitster@pobox.com>
Date
May 7, 2020, 19:31 UTC
Message-ID
<xmqq5zd74k56.fsf@gitster.c.googlers.com>
In-Reply-To
<20200507172201.GD26677@syl.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 25 quoted lines
> Hi Junio,
>
> On Wed, May 06, 2020 at 01:18:30PM -0700, Junio C Hamano wrote:
>> These commands take the --quiet option for their own operation, but
>> they forget to pass the option down when they invoke "git gc --auto"
>> internally.
>>
>> Teach them to do so using the run_auto_gc() helper we added in the
>> previous step.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>  builtin/am.c     | 3 +--
>>  builtin/commit.c | 3 +--
>>  builtin/merge.c  | 3 +--
>>  builtin/rebase.c | 3 +--
>>  4 files changed, 4 insertions(+), 8 deletions(-)
>
> Very nicely done. Sorry that these took me a little while to look at.
> This and the patch before it both have my:
>
>   Reviewed-by: Taylor Blau <me@ttaylorr.com>
>
> Thanks,
> Taylor
Thanks.
Previous: Taylor BlauNext: Junio C Hamano
Message 12 of 13 in “option -q not passed from "git commit" to "git gc --auto"”
  1. Pierrick GaudryMay 6, 2020
  2. Taylor BlauMay 6, 2020
  3. Taylor BlauMay 6, 2020
  4. Taylor BlauMay 6, 2020
  5. Junio C HamanoMay 6, 2020
  6. Re* option -q not passed from "git commit" to "git gc --auto"Junio C Hamano, May 6, 2020
  7. 2/2 auto-gc: pass --quiet down from am, commit, merge and rebaseJunio C Hamano, May 6, 2020
  8. Junio C HamanoMay 6, 2020
  9. 0/2 Pass down "--quiet" to "gc --auto"Junio C Hamano, May 6, 2020
  10. 2/2 auto-gc: pass --quiet down from am, commit, merge and rebaseJunio C Hamano, May 6, 2020
  11. Taylor BlauMay 7, 2020
  12. Junio C HamanoMay 7, 2020
  13. 1/2 auto-gc: extract a reusable helper from "git fetch"Junio C Hamano, May 6, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.