git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Pass down "--quiet" to "gc --auto"

From
Junio C Hamano <gitster@pobox.com>
Date
May 6, 2020, 20:18 UTC
Message-ID
<20200506201830.92818-1-gitster@pobox.com>
In-Reply-To
<20200506094327.GC31637@rillettes>

A handful commands take "--quiet" from their command line, but forgets to pass it down, when they trigger an auto gc, to the "git gc --auto" they internally invoke.

Back in 1991006c (fetch: convert argv_gc_auto to struct argv_array, 2014-08-16), we patched "git fetch" but seems to have forgotten doing the same for "git merge". Since then, rewrite of "git am" and "git rebase" in C spread the same problem into two more codepaths.

Let's clean them up once and for all.
Junio C Hamano (2):
  run_auto_gc(): extract a reusable helper
  auto-gc: pass --quiet down from am, commit, merge and rebase
 builtin/am.c     |  3 +--
 builtin/commit.c |  3 +--
 builtin/fetch.c  | 10 ++--------
 builtin/merge.c  |  3 +--
 builtin/rebase.c |  3 +--
 run-command.c    | 13 +++++++++++++
 run-command.h    |  5 +++++
 7 files changed, 24 insertions(+), 16 deletions(-)
-- 
2.26.2-561-g07d8ea56f2
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 13 in “option -q not passed from "git commit" to "git gc --auto"”
  1. Pierrick GaudryMay 6, 2020
  2. Taylor BlauMay 6, 2020
  3. Taylor BlauMay 6, 2020
  4. Taylor BlauMay 6, 2020
  5. Junio C HamanoMay 6, 2020
  6. Re* option -q not passed from "git commit" to "git gc --auto"Junio C Hamano, May 6, 2020
  7. 2/2 auto-gc: pass --quiet down from am, commit, merge and rebaseJunio C Hamano, May 6, 2020
  8. Junio C HamanoMay 6, 2020
  9. 0/2 Pass down "--quiet" to "gc --auto"Junio C Hamano, May 6, 2020
  10. 2/2 auto-gc: pass --quiet down from am, commit, merge and rebaseJunio C Hamano, May 6, 2020
  11. Taylor BlauMay 7, 2020
  12. Junio C HamanoMay 7, 2020
  13. 1/2 auto-gc: extract a reusable helper from "git fetch"Junio C Hamano, May 6, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.