[PATCH 0/2] Pass down "--quiet" to "gc --auto"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 6, 2020, 20:18 UTC
- Message-ID
- <20200506201830.92818-1-gitster@pobox.com>
- In-Reply-To
- <20200506094327.GC31637@rillettes>
A handful commands take "--quiet" from their command line, but forgets to pass it down, when they trigger an auto gc, to the "git gc --auto" they internally invoke.
Back in 1991006c (fetch: convert argv_gc_auto to struct argv_array, 2014-08-16), we patched "git fetch" but seems to have forgotten doing the same for "git merge". Since then, rewrite of "git am" and "git rebase" in C spread the same problem into two more codepaths.
Let's clean them up once and for all.
Junio C Hamano (2): run_auto_gc(): extract a reusable helper auto-gc: pass --quiet down from am, commit, merge and rebase
builtin/am.c | 3 +-- builtin/commit.c | 3 +-- builtin/fetch.c | 10 ++-------- builtin/merge.c | 3 +-- builtin/rebase.c | 3 +-- run-command.c | 13 +++++++++++++ run-command.h | 5 +++++ 7 files changed, 24 insertions(+), 16 deletions(-)
-- 2.26.2-561-g07d8ea56f2