Re: [PATCH v5 1/3] pull: refactor fast-forward check

Felipe Contreras <felipe.contreras@gmail.com> writes:

> It's much cleaner this way.

It is obvious that a focused single purpose helper with less indentation is easier to follow both at the calling site and the implementation itself.

"It's much cleaner" is not something you need to say.

If you were making it uglier, but other benefits outweigh the ugliness, that may deserve to be said, but that is not the case here.

> Also, we would like to be able to make this check before the decision to
> rebase is made.

... in a future step.

That is something we want to say upfront, not "Also".

The patch itself looks quite straightforward.

Thanks.