Re: [PATCH v5 3/3] pull: display default warning only when non-ff
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Dec 14, 2020, 21:40 UTC
- Message-ID
- <5fd7dbe1eb26d_d5985208e1@natae.notmuch>
- In-Reply-To
- <xmqqo8iwje0h.fsf@gitster.c.googlers.com>
Junio C Hamano wrote:
Show 13 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes: > > >> The original author of this test cared that pulling c1 with --rebase > >> into c0 succeeds, and that it does not give the error message. > > > > I prefer not to attempt to read minds (plus, the author might have not > > cared that the pulling succeeds), and anyway; that's not what matters. > > ... > > Again, I don't particularly care to mindread what the test authors might > > have cared about. > > You do not have to read mind. What is written in the test is clear > enough: run "git pull --rebase . c1" into c0 and see what happens.
That is precisely my point: it is written in the test, no mindreading neccessary.
-- Felipe Contreras