Re: [PATCH 0/5] avoid peeking into `struct lock_file`

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2021, 11:55 UTC
Message-ID: <xmqq5z4as2j9.fsf@gitster.c.googlers.com>
In-Reply-To: <a401a6a7-fc15-9f26-2345-651964cf7b5d@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 17 quoted lines

> On 1/5/2021 2:23 PM, Martin Ågren wrote:
>> I made a comment in [1] about how we could avoid peeking into a `struct
>> lock_file` and instead use a helper function that we happen to have at
>> our disposal. I then grepped around a bit and found that we're pretty
>> good at avoiding such peeking at the moment, but that we could do
>> a bit better.
>> 
>> Here's a series to avoid such `lk.tempfile.foo` in favor of
>> `get_lock_file_foo(&lk)`.
>> 
>> [1] https://lore.kernel.org/git/CAN0heSrOKr--GenbowHP+iwkijbg5pCeJLq+wz6NXCXTsfcvGg@mail.gmail.com/
>
> Thanks for being diligent and keeping the code clean.
>
> This series is good-to-go.
>
> Reviewed-by: Derrick Stolee <dstolee@microsoft.com>

Thanks, both.