git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] avoid peeking into `struct lock_file`

From
Derrick Stolee <stolee@gmail.com>
Date
Jan 6, 2021, 02:16 UTC
Message-ID
<a401a6a7-fc15-9f26-2345-651964cf7b5d@gmail.com>
In-Reply-To
<cover.1609874026.git.martin.agren@gmail.com>
On 1/5/2021 2:23 PM, Martin Ågren wrote:
Show 10 quoted lines
> I made a comment in [1] about how we could avoid peeking into a `struct
> lock_file` and instead use a helper function that we happen to have at
> our disposal. I then grepped around a bit and found that we're pretty
> good at avoiding such peeking at the moment, but that we could do
> a bit better.
> 
> Here's a series to avoid such `lk.tempfile.foo` in favor of
> `get_lock_file_foo(&lk)`.
> 
> [1] https://lore.kernel.org/git/CAN0heSrOKr--GenbowHP+iwkijbg5pCeJLq+wz6NXCXTsfcvGg@mail.gmail.com/
Thanks for being diligent and keeping the code clean.
This series is good-to-go.
Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
Previous: Martin ÅgrenNext: Junio C Hamano
Message 7 of 13 in “avoid peeking into `struct lock_file`”
  1. 0/5 avoid peeking into `struct lock_file`Martin Ågren, Jan 5, 2021
  2. 4/5 refs/files-backend: don't peek into `struct lock_file`Martin Ågren, Jan 5, 2021
  3. 3/5 midx: don't peek into `struct lock_file`Martin Ågren, Jan 5, 2021
  4. 2/5 commit-graph: don't peek into `struct lock_file`Martin Ågren, Jan 5, 2021
  5. 1/5 builtin/gc: don't peek into `struct lock_file`Martin Ågren, Jan 5, 2021
  6. 5/5 read-cache: try not to peek into `struct {lock_,temp}file`Martin Ågren, Jan 5, 2021
  7. Derrick StoleeJan 6, 2021
  8. Junio C HamanoJan 6, 2021
  9. Junio C HamanoJan 6, 2021
  10. Derrick StoleeJan 7, 2021
  11. Martin ÅgrenJan 7, 2021
  12. Junio C HamanoJan 7, 2021
  13. Martin ÅgrenJan 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.