Re: [PATCH v2] receive-pack: ignore SIGPIPE while reporting status to client

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 9, 2021, 23:03 UTC
Message-ID: <xmqq5yt10w5r.fsf@gitster.g>
In-Reply-To: <CFLKOIVJ8EX0.2PWQ6PCXZ340A@diabtop>

"Robin Jarry" <robin@jarry.cc> writes:

Show 13 quoted lines

>> > +		sigchain_push(SIGPIPE, SIG_IGN);
>> >  		if (pack_lockfile)
>> >  			unlink_or_warn(pack_lockfile);
>>
>> Shouldn't we start ignoring SIGPIPE here, not before we try to
>> unlink the lockfile?
>
> I initially wanted to avoid getting SIGPIPE'd while printing a warning
> if the lockfile cannot be unlinked. Maybe this means the repository
> integrity is compromised and we are well beyond ensuring post-receive is
> executed or not. I do not know git internals well enough to be sure.
>
> What do you think?

I think that push/pop pair should surround the part that reports the status, as the proposed commit log message said.

Thanks.