Re: [RFC PATCH] receive-pack: run post-receive before reporting status

From

RJRobin Jarry <robin.jarry@6wind.com>

Date

Nov 6, 2021, 21:32 UTC

Message-ID

<CFJ0O7HEP2TY.NSQD8094SYCF@diabtop>

In-Reply-To

<211106.86y261g88n.gmgdl@evledraar.gmail.com>

Hi Ævar,

Ævar Arnfjörð Bjarmason, Nov 06, 2021 at 06:03:

> FWIW we include the date when mentioning commits. E.g. ec7dbd145bd
> (receive-pack: allow hooks to ignore its standard input stream,
> 2014-09-12).

OK, noted.

> I think the discussion at [1] is current to everything you're seeing
> here.

Thanks I had missed this thread.

> tl;dr: Even with this change you're not guaranteed to run your hook.

[snip]

> But as noted in [1] there's a way forward to having our cake & eating it
> too. I.e. when we into that on the server-side we can try a little
> harder not to die, and run post-receive anyway, and in either case it
> would be nice if we'd run it after disconnecting from the client, so it
> doesn't have to wait for it.

Cheers,

-- 
Robin