Re: [PATCH v2 0/3] Fix LLP64 `(size_t)1` compatibility VS C4334 warnings

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 1, 2021, 22:49 UTC
Message-ID: <xmqq5ys8ym8s.fsf@gitster.g>
In-Reply-To: <20211201002902.1042-1-philipoakley@iee.email>

Philip Oakley <philipoakley@iee.email> writes:

Show 24 quoted lines

> Since V1 (gitster/po/size-t-for-vs)
> https://lore.kernel.org/git/20211126113614.709-1-philipoakley@iee.email/
>
> Former patch 1/4 was dropped as it was already in Junio's tree.
>
> Patch 1/3 corrects my spelling mistake.
>
> Patch 2/3 has added extra spacing around the << operator as suggested by
> Stollee[1].
>
> Patch 3/3 removes the superceded commit message comment regarding
> backporting the patch onto maint.
>
> The Visual Studio MSVC compilation reports a number of C4334 "was 64-bit
> shift intended" size mismatch warnings. In most of these cases a size_t
> is ANDed (masked) with a bit shift of 1, or 1U. On LLP64 systems the unity
> value is 32 bits, while size_t is 64 bits. 
>
> The fix is to upcast the unity value to size_t.   
>
> The first [dropped] patch had been reported [2] by René Scharfe as an extra patch
> to the rs/mergesort series.
>
> These fixes clear all the current C4334 warnings.

Thanks.  Will queue; let's have it in 'next'.