git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ds/sparse-checkout-requires-per-worktree-config

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 25, 2021, 22:20 UTC
Message-ID
<xmqq5yrc5ntn.fsf@gitster.g>
In-Reply-To
<CABPp-BFiMy55mCMJSHk9PmKa8EUd-6mR5z5xM7J3P2dZBjRq5g@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 31 quoted lines
> On Fri, Dec 24, 2021 at 6:11 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>> > * ds/sparse-checkout-requires-per-worktree-config (2021-12-21) 5 commits
>> >  - sparse-checkout: use repo_config_set_worktree_gently()
>> >  - config: add repo_config_set_worktree_gently()
>> >  - worktree: add upgrade_to_worktree_config()
>> >  - config: make some helpers repo-aware
>> >  - setup: use a repository when upgrading format
>> >
>> >  "git sparse-checkout" wants to work with per-worktree configration,
>> >  but did not work well in a worktree attached to a bare repository.
>> >
>> >  Expecting a redesign?
>> >  cf. <CABPp-BG7nwsdEYrnfqhAbWU4ndJHcqGf6RS_6DzJittuNVLvoA@mail.gmail.com>
>> >  source: <pull.1101.v2.git.1640114048.gitgitgadget@gmail.com>
>>
>> FWIW, this topic by itself passes its self test, but when queued
>> near the tip of 'seen', it seems to break t1091.
>>
>> For an example run that fails on win+VS test (8), see
>> https://github.com/git/git/runs/4629824103
>
> Unrelated to your comment, other than being about this same series:
>
> I think "redesign" is too strong a word here.  I think the patches are
> a useful start...and might even represent the majority of the code
> needed; it's just that they are focusing too narrowly.  core.worktree
> should also be handled, and I think we should include fixes at the
> `git worktree add` level, not just `git sparse-checkout {init,set}`.
Yup, the last one part is what I meant by "redesign".
Previous: Elijah NewrenNext: Eric Sunshine
Message 6 of 11 in “What's cooking in git.git (Dec 2021, #05; Thu, 23)”
  1. Junio C HamanoDec 23, 2021
  2. ab/make-dependency (was "What's cooking in git.git (Dec 2021, #05; Thu, 23))Ævar Arnfjörð Bjarmason, Dec 24, 2021
  3. Junio C HamanoDec 26, 2021
  4. Junio C HamanoDec 25, 2021
  5. ds/sparse-checkout-requires-per-worktree-config (Was: Re: What's cooking in git.git (Dec 2021, #05; Thu, 23))Elijah Newren, Dec 25, 2021
  6. Junio C HamanoDec 25, 2021
  7. Eric SunshineDec 25, 2021
  8. Teng LongDec 25, 2021
  9. Ævar Arnfjörð BjarmasonDec 26, 2021
  10. Teng LongDec 27, 2021
  11. ab/only-single-progress-at-once (was: What's cooking in git.git (Dec 2021, #05; Thu, 23))Ævar Arnfjörð Bjarmason, Dec 26, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.