ds/sparse-checkout-requires-per-worktree-config (Was: Re: What's cooking in git.git (Dec 2021, #05; Thu, 23))

From: Elijah Newren <newren@gmail.com>
Date: Dec 25, 2021, 02:49 UTC
Message-ID: <CABPp-BFiMy55mCMJSHk9PmKa8EUd-6mR5z5xM7J3P2dZBjRq5g@mail.gmail.com>
In-Reply-To: <xmqqsfuh5tz4.fsf@gitster.g>

On Fri, Dec 24, 2021 at 6:11 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 22 quoted lines

>
> Junio C Hamano <gitster@pobox.com> writes:
>
> > * ds/sparse-checkout-requires-per-worktree-config (2021-12-21) 5 commits
> >  - sparse-checkout: use repo_config_set_worktree_gently()
> >  - config: add repo_config_set_worktree_gently()
> >  - worktree: add upgrade_to_worktree_config()
> >  - config: make some helpers repo-aware
> >  - setup: use a repository when upgrading format
> >
> >  "git sparse-checkout" wants to work with per-worktree configration,
> >  but did not work well in a worktree attached to a bare repository.
> >
> >  Expecting a redesign?
> >  cf. <CABPp-BG7nwsdEYrnfqhAbWU4ndJHcqGf6RS_6DzJittuNVLvoA@mail.gmail.com>
> >  source: <pull.1101.v2.git.1640114048.gitgitgadget@gmail.com>
>
> FWIW, this topic by itself passes its self test, but when queued
> near the tip of 'seen', it seems to break t1091.
>
> For an example run that fails on win+VS test (8), see
> https://github.com/git/git/runs/4629824103

Unrelated to your comment, other than being about this same series:

I think "redesign" is too strong a word here. I think the patches are a useful start...and might even represent the majority of the code needed; it's just that they are focusing too narrowly. core.worktree should also be handled, and I think we should include fixes at the `git worktree add` level, not just `git sparse-checkout {init,set}`.