Re: [PATCH v2 0/3] reset: make --no-refresh the only way to skip index refresh

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 25, 2022, 16:35 UTC
Message-ID: <xmqq5yo2c7ng.fsf@gitster.g>
In-Reply-To: <202ec3ce-76ee-a46b-3235-e801339eb153@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 20 quoted lines

> On 3/24/2022 1:33 PM, Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>>> #leftoverbit: we may want to discuss if it is a good idea to teach
>>> OPT_BOOL() to list "--[no-]<option>" in "git cmd -h", instead of
>>> just "--<option>".
>
> Good idea!
>
>> Unfortunately, I merged these already to 'next' before seeing your
>> comment, so we'd need to go incremental.
>> 
>> How about this?
>
>> -		OPT_BOOL(0, "refresh", &refresh,
>> +		OPT_BOOL(0, "no-refresh", &no_refresh,
>>  				N_("skip refreshing the index after reset")),
>
> I'm pleasantly surprised that this still allows --refresh (in addition to
> --no-no-refresh). So, the only meaningful functional change is indeed the
> -h output.

Yeah, it is a pleasant easter egg surprise that --refresh is taken as the opposite but its cousin that we allow --no-no-refresh is somehow questionably ugly, albeit it does not hurt anybody, except for purists who would certainly complain that --no-no-no-refresh is not understood.