Re: [PATCH v2 0/3] reset: make --no-refresh the only way to skip index refresh

From: Derrick Stolee <derrickstolee@github.com>
Date: Mar 25, 2022, 15:04 UTC
Message-ID: <202ec3ce-76ee-a46b-3235-e801339eb153@github.com>
In-Reply-To: <xmqq7d8jjlwp.fsf@gitster.g>

On 3/24/2022 1:33 PM, Junio C Hamano wrote:

> Junio C Hamano <gitster@pobox.com> writes:
>> #leftoverbit: we may want to discuss if it is a good idea to teach
>> OPT_BOOL() to list "--[no-]<option>" in "git cmd -h", instead of
>> just "--<option>".

Good idea!

> Unfortunately, I merged these already to 'next' before seeing your
> comment, so we'd need to go incremental.
> 
> How about this?

> -		OPT_BOOL(0, "refresh", &refresh,
> +		OPT_BOOL(0, "no-refresh", &no_refresh,
>  				N_("skip refreshing the index after reset")),

I'm pleasantly surprised that this still allows --refresh (in addition to --no-no-refresh). So, the only meaningful functional change is indeed the -h output.

Thanks, -Stolee