Re: [PATCH v3 0/4] commit-graph: fsck zero/non-zero generation number fixes

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2023, 23:22 UTC
Message-ID: <xmqq5y58nfp0.fsf@gitster.g>
In-Reply-To: <20230821215518.GA1811034@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The end result looks good to me. I probably would have squashed at least
> 2+4 into one, and probably just squashed 3 into that as well. But I am
> OK with it as-is, too, and it is definitely diminishing returns to keep
> polishing it.

I had the same impression. The endgame after applying all four looks very sensible but the changes necessary to fix things while keeping ZERO_EXISTS and NUMBER_EXISTS looked more or less like unnecessary detour.

> Thanks for assembling it into a usable form.

Yup. Will queue almost as-is (except for dropping the repeated "commit-graph" on the title of the last step).

THanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.