Re: [PATCH v3 0/4] commit-graph: fsck zero/non-zero generation number fixes

From: Jeff King <peff@peff.net>
Date: Aug 21, 2023, 21:55 UTC
Message-ID: <20230821215518.GA1811034@coredump.intra.peff.net>
In-Reply-To: <cover.1692653671.git.me@ttaylorr.com>

On Mon, Aug 21, 2023 at 05:34:32PM -0400, Taylor Blau wrote:

Show 8 quoted lines

> Here's a(nother) small reroll of a series that I sent which expanded on
> a patch that Peff sent earlier in the thread to remove a section of
> unreachable code that was noticed by Coverity in the
> `verify_one_commit_graph()` function.
> 
> The first few patches are the same, but the fourth (now final) patch is
> modified to track a single example of a commit with zero and non-zero
> generation to only emit the warning once at the end of processing.

The end result looks good to me. I probably would have squashed at least 2+4 into one, and probably just squashed 3 into that as well. But I am OK with it as-is, too, and it is definitely diminishing returns to keep polishing it.

Thanks for assembling it into a usable form.

-Peff