Re: [PATCH v2 1/2] t: add a test helper to truncate files

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 13, 2023, 20:32 UTC
Message-ID: <xmqq5y3az2ju.fsf@gitster.g>
In-Reply-To: <ZSmmD5sz7TPWCGRd@tapette.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 12 quoted lines

> On 2023-10-12 at 22:52:59, Junio C Hamano wrote:
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> 
>> > +	fd = open(argv[1], O_WRONLY | O_CREAT, 0600);
>> > +	if (fd < 0)
>> > +		die_errno("failed to open file %s", argv[1]);
>> 
>> contrib/coccinelle/xopen.cocci tells us to write this simply as
>> 
>> 	fd = xopen(argv[1], O_WRONLY | O_CREAT, 0600);
>
> Sure, I can do that.

Unless there are other changes needed, I'll handle it on this end.

Thanks.