Re: [PATCH v2 1/2] t: add a test helper to truncate files

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Oct 13, 2023, 20:23 UTC
Message-ID: <ZSmnXpQ3hpLM6Xpf@tapette.crustytoothpaste.net>
In-Reply-To: <CAPig+cSUvyCS-NOYOoJAmg7LGyU5Dqky5HyS-QTNW1QoHj-0bA@mail.gmail.com>

On 2023-10-12 at 17:49:13, Eric Sunshine wrote:

Show 7 quoted lines

> > +       sz = strtoumax(argv[2], &p, 0);
> > +       if (*p)
> > +               die("invalid size");
> 
> Do you want to check 'errno' here, as well (probably before the '*p' check)?
> 
> Or is that being too defensive for a 'test-tool' command?

I don't believe that's necessary. The Linux manual page leads me to believe that if *argv[2] is not 0 but *p is 0, then the entire string is valid, which would imply that errno is not set. I'm happy to ignore for the moment the case where the user specifies "" as the argument, because it is a test helper and "don't do weird, unexpected things with the test helper without looking at the source code first" is legitimate advice for Git developers.

If this were user-facing, improved robustness would be warranted, I agree.

-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA