Re: [PATCH 1/7] chunk-format: introduce `pair_chunk_expect()` helper
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 10, 2023, 23:39 UTC
- Message-ID
- <xmqq5y29uqi9.fsf@gitster.g>
- In-Reply-To
- <20231110220142.GH2758295@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I think dropping those is a bad direction. The point of adding > pair_chunk_expect() is that we could use it consistently.
I think so, too. If we are adding a helper to avoid common mistakes, and if it cannot be used in some situations, then the helper needs to be improved.