From: Junio C Hamano Date: Fri, 10 Nov 2023 23:39:58 GMT Subject: Re: [PATCH 1/7] chunk-format: introduce `pair_chunk_expect()` helper Message-ID: In-Reply-To: <20231110220142.GH2758295@coredump.intra.peff.net> Jeff King writes: > I think dropping those is a bad direction. The point of adding > pair_chunk_expect() is that we could use it consistently. I think so, too. If we are adding a helper to avoid common mistakes, and if it cannot be used in some situations, then the helper needs to be improved.