Re: [PATCH 0/5] diff output_prefix cleanups

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 4, 2024, 19:31 UTC
Message-ID: <xmqq5xq7ekb8.fsf@gitster.g>
In-Reply-To: <e38449d8-190a-49af-85b6-a628e14379d6@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 17 quoted lines

> On 10/3/24 5:05 PM, Jeff King wrote:
>> On Thu, Oct 03, 2024 at 11:58:41AM +0000, Derrick Stolee via GitGitGadget wrote:
>
>>> Note to the maintainer: feel free to take only the first patch, as Peff
>>> replied that he may work on the remaining cleanup independently (but I had
>>> already prepared patches 2 & 3).
>> Oh, I wasn't expecting you to go to that trouble, and had already
>> polished them up myself. :)
>
> It's perfectly fine that we were attempting to save each other work.
>
>> So certainly your patch 1 looks good to me now. Here's what I would
>> put on top (but I would suggest making it a separate branch, since yours
>> is a fairly urgent fix and mine is all cleanup).
>
> I approve of this plan. Please only consider my first patch and drop
> the others.

Yup.  Thanks, both.  The result looked very sensible.