Re: [PATCH 0/5] diff output_prefix cleanups

From: Derrick Stolee <stolee@gmail.com>
Date: Oct 4, 2024, 19:33 UTC
Message-ID: <039920ed-57a8-4c49-8914-5f071a548eca@gmail.com>
In-Reply-To: <20241003210548.GB11180@coredump.intra.peff.net>

On 10/3/24 5:05 PM, Jeff King wrote:
 > Here's what I would> put on top (but I would suggest making it a separate 
branch, since yours

Show 7 quoted lines

> is a fairly urgent fix and mine is all cleanup).
> 
>    [1/5]: line-log: use diff_line_prefix() instead of custom helper
>    [2/5]: diff: drop line_prefix_length field
>    [3/5]: diff: return const char from output_prefix callback
>    [4/5]: diff: return line_prefix directly when possible
>    [5/5]: diff: store graph prefix buf in git_graph struct

I've reviewed these patches and they look good to me. Thanks for taking the time to split them up carefully to help review go so smoothly.

>   7 files changed, 28 insertions(+), 43 deletions(-)

Excellent to see the line reduction, too.

Thanks, -Stolee