Re: a less-invasive racy-leak fix, was Re: What's cooking in git.git (Dec 2024, #11; Mon, 30)

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 2, 2025, 19:33 UTC
Message-ID: <xmqq5xmxui37.fsf@gitster.g>
In-Reply-To: <20250102190623.GA848764@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

>   <SUBJECT: DESCRIBE YOUR REVERT HERE>
>
>   Revert the following commits:
>
>      - 7a8d9efc26 (grep: work around LSan threading race with barrier, 2024-12-29)
>      - 526c0a851b (index-pack: work around LSan threading race with barrier, 2024-12-29)
>      - 7d0037b59a (thread-utils: introduce optional barrier type, 2024-12-29)

Ah, I love it.

Show 8 quoted lines

> You could perhaps even auto-populate the subject with:
>
>   Revert jk/lsan-race-with-barrier~3..jk/lsan-race-with-barrier
>
> similar to how git-merge uses "Merge branch ...". But it's a little
> clunky to read, and unlike merge, it's a lot easier to use names that
> are not very meaningful (e.g., I checked out a new branch based on that
> one and then used HEAD~3..HEAD, which is worthless to mention).

Yup, agreed. The commit title is much less interesting to automate than the "we revert these three" list.

Thanks.