Re: [PATCH 4/6] test-lib: simplify leak-log checking

From: Jeff King <peff@peff.net>
Date: Jan 7, 2025, 07:01 UTC
Message-ID: <20250107070104.GA584401@coredump.intra.peff.net>
In-Reply-To: <Z3uMyQ-YfQFI8qmH@pks.im>

On Mon, Jan 06, 2025 at 08:56:57AM +0100, Patrick Steinhardt wrote:

Show 8 quoted lines

> > Plus I don't think "find" propagates the exit code from -exec anyway. I
> > think you can check the exit status with more find logic, so you'd then
> > use a conditional -print for each file like:
> 
> It should. Quoting find(1):
> 
>     If any invocation with the `+' form returns a non-zero value as exit
>     status, then find returns a non-zero exit status.

Ah, right. I tried using ';' to look at individual files, and it does ignore the code. But of course we don't need to know which logs had leaks, only that there was at least one.

I think we can make it even simpler, though. I'll post patches in a moment.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.