Re: [PATCH v3] reflog: close leak of reflog expire entry

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 22, 2025, 23:21 UTC
Message-ID: <xmqq5xfjrew1.fsf@gitster.g>
In-Reply-To: <fd14c857-63a8-41e7-8361-bc816d4a47c4@intel.com>

Jacob Keller <jacob.e.keller@intel.com> writes:

Show 14 quoted lines

>> This needs to pass &data.policy.opts, no?
>> 
>
> You're right... I think I fixed that and forgot to actually commit it
> before sending. Ugh.
>
>> I think we might also want this test on top (or I'd be happy to see it
>> squashed in). It shows off your fix when built with SANITIZE=leak, and
>> also catches the bug that v2 of your patch had.
>> 
>> -Peff
>> 
>
> Sounds good. I'll send a v4 which squashes this in.

OK, or you can tell me to squash what I queued on the jk/unleak-reflog-expire-entry topic that ends at 7c091149 (fixup! reflog: close leak of reflog expire entry, 2025-07-22) down into a single patch (or two to keep Peff's test saparate).

Thanks.