Re: [PATCH v3] reflog: close leak of reflog expire entry

From: Jacob Keller <jacob.e.keller@intel.com>
Date: Jul 22, 2025, 23:22 UTC
Message-ID: <72f13c54-d5c7-4366-bba2-b641d9e2b0c7@intel.com>
In-Reply-To: <xmqq5xfjrew1.fsf@gitster.g>

On 7/22/2025 4:21 PM, Junio C Hamano wrote:

Show 23 quoted lines

> Jacob Keller <jacob.e.keller@intel.com> writes:
> 
>>> This needs to pass &data.policy.opts, no?
>>>
>>
>> You're right... I think I fixed that and forgot to actually commit it
>> before sending. Ugh.
>>
>>> I think we might also want this test on top (or I'd be happy to see it
>>> squashed in). It shows off your fix when built with SANITIZE=leak, and
>>> also catches the bug that v2 of your patch had.
>>>
>>> -Peff
>>>
>>
>> Sounds good. I'll send a v4 which squashes this in.
> 
> OK, or you can tell me to squash what I queued on the
> jk/unleak-reflog-expire-entry topic that ends at 7c091149 (fixup!
> reflog: close leak of reflog expire entry, 2025-07-22) down into a
> single patch (or two to keep Peff's test saparate).
> 
> Thanks.

I am about to send a v4 that squashes Peff's work in and adds a Co-developed-by tag. I think that makes the most sense.