Re: [PATCH] t4014: fix call to `test_expect_success ()`

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 24, 2026, 15:38 UTC
Message-ID: <xmqq5x6l2q5y.fsf@gitster.g>
In-Reply-To: <acKqvI0EhaORjoD7@exploit>

Mirko Faina <mroik@delayed.space> writes:

Show 21 quoted lines

> On Tue, Mar 24, 2026 at 03:52:30PM +0100, Patrick Steinhardt wrote:
>> We have added a couple of new tests to t4014 in 6005932d95
>> (format-patch: add ability to use alt cover format, 2026-03-07). One of
>> the tests has typoed the call to `test_expect_success ()` and instead
>> invokes `test_expected_success ()`. Fix this.
>> 
>> Signed-off-by: Patrick Steinhardt <ps@pks.im>
>> ---
>> Hi,
>> 
>> this fixes a test bug in one of the new tests introduced via
>> "mf/format-patch-cover-letter-format". Thanks!
>> 
>> Patrick
>
> This has already been fixed in a follow-up series under
> mf/format-patch-cover-letter-format [1].
>
> Thank you
>
> [1] https://lore.kernel.org/git/5d061d6398bae368a7cc95700b5df44854d1d8e8.1774284699.git.mroik@delayed.space

Could either of you remind us why "make test" did not catch this?

Thanks.