git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4014: fix call to `test_expect_success ()`

From
Mirko Faina <mroik@delayed.space>
Date
Mar 24, 2026, 15:18 UTC
Message-ID
<acKqvI0EhaORjoD7@exploit>
In-Reply-To
<20260324-b4-pks-t4014-fix-test-execution-v1-1-ac83c1bcc828@pks.im>
On Tue, Mar 24, 2026 at 03:52:30PM +0100, Patrick Steinhardt wrote:
Show 13 quoted lines
> We have added a couple of new tests to t4014 in 6005932d95
> (format-patch: add ability to use alt cover format, 2026-03-07). One of
> the tests has typoed the call to `test_expect_success ()` and instead
> invokes `test_expected_success ()`. Fix this.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> Hi,
> 
> this fixes a test bug in one of the new tests introduced via
> "mf/format-patch-cover-letter-format". Thanks!
> 
> Patrick

This has already been fixed in a follow-up series under mf/format-patch-cover-letter-format [1].

Thank you
[1] https://lore.kernel.org/git/5d061d6398bae368a7cc95700b5df44854d1d8e8.1774284699.git.mroik@delayed.space
Previous: Patrick SteinhardtNext: Junio C Hamano
Message 2 of 16 in “t4014: fix call to `test_expect_success ()`”
  1. t4014: fix call to `test_expect_success ()`Patrick Steinhardt, Mar 24, 2026
  2. Mirko FainaMar 24, 2026
  3. Junio C HamanoMar 24, 2026
  4. Mirko FainaMar 24, 2026
  5. Junio C HamanoMar 24, 2026
  6. Re* [PATCH] t4014: fix call to `test_expect_success ()`Junio C Hamano, Mar 24, 2026
  7. t6002: make test "set -e" cleanJunio C Hamano, Mar 24, 2026
  8. test-lib: catch misspelt 'test_expect_successo'Junio C Hamano, Mar 24, 2026
  9. Jeff KingMar 24, 2026
  10. Junio C HamanoMar 24, 2026
  11. Jeff KingMar 25, 2026
  12. t0008: make test "set -e" cleanJunio C Hamano, Mar 24, 2026
  13. t7450: make test "set -e" cleanJunio C Hamano, Mar 24, 2026
  14. Eric SunshineMar 24, 2026
  15. Junio C HamanoMar 24, 2026
  16. Patrick SteinhardtMar 25, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.