Re: [PATCH v2 4/5] builtin/refs: add "create" subcommand
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 29, 2026, 20:58 UTC
- Message-ID
- <xmqq5x31ukqv.fsf@gitster.g>
- In-Reply-To
- <20260617-pks-refs-writing-subcommands-v2-4-07f3d18336f9@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> + if (repo_get_oid_with_flags(repo, argv[1], &newoid, GET_OID_SKIP_AMBIGUITY_CHECK))
> + die(_("invalid object ID: '%s'"), argv[1]);
> + if (is_null_oid(&newoid))
> + die(_("cannot create reference with null old object ID"));An apparent typo here, "with null old" -> "with null new object name".
Other than that, I think this one is good.