From: Junio C Hamano Date: Mon, 29 Jun 2026 20:58:32 GMT Subject: Re: [PATCH v2 4/5] builtin/refs: add "create" subcommand Message-ID: In-Reply-To: <20260617-pks-refs-writing-subcommands-v2-4-07f3d18336f9@pks.im> Patrick Steinhardt writes: > + if (repo_get_oid_with_flags(repo, argv[1], &newoid, GET_OID_SKIP_AMBIGUITY_CHECK)) > + die(_("invalid object ID: '%s'"), argv[1]); > + if (is_null_oid(&newoid)) > + die(_("cannot create reference with null old object ID")); An apparent typo here, "with null old" -> "with null new object name". Other than that, I think this one is good.