git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/3] relative_path should honor DOS and UNC paths

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 18, 2013, 16:00 UTC
Message-ID
<xmqq4n9iw24q.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CANYiYbF1XwKbD13AMZhE1c4hGMqVzpH9hZ-J8Gk-8AVFUCnn0g@mail.gmail.com>
Jiang Xin <worldhello.net@gmail.com> writes:
Show 9 quoted lines
> 2013/9/18 Junio C Hamano <gitster@pobox.com>:
>>> +     if (!is_dir_sep(*path) || !is_dir_sep(*(path+1)) || is_dir_sep(*(path+2)))
>>> +             return 0;
>> If path[1] == '\0', it would be !is_dir_sep() and we end up
>> inspecting past the end of the string?
>
> The funciton "is_unc_path" will return false (0), if path is
> "", "/", "//", "///three/slashes/", or "/usr/local".
> So the problem is ?

If path[1] == '\0' (e.g. path="/"), !is_dir_sep(path[1]) is true, not false (as I misread earlier), so we hit an early return and will not peek path[2]. So no problem. Sorry for the noise.

But I agree with J6t and Torsten in near-by thread that the simpler one that does not worry about // should be done as a separate patch and //, if we decide to do it, should build on top.

Thanks.
Previous: Jiang XinNext: Jiang Xin
Message 28 of 48 in “Regression in e02ca72: git svn rebase is broken on Windows”
  1. TvangesteSep 10, 2013
  2. Johannes SchindelinSep 10, 2013
  3. TvangesteSep 10, 2013
  4. Johannes SchindelinSep 10, 2013
  5. TvangesteSep 10, 2013
  6. Johannes SixtSep 10, 2013
  7. TvangesteSep 10, 2013
  8. Junio C HamanoSep 10, 2013
  9. Karsten BleesSep 10, 2013
  10. Jiang XinSep 11, 2013
  11. Jiang XinSep 11, 2013
  12. Johannes SixtSep 11, 2013
  13. 1/2 relative_path should honor dos_drive_prefixJiang Xin, Sep 12, 2013
  14. 2/2 Use simpler relative_path when set_git_dirJiang Xin, Sep 12, 2013
  15. Johannes SixtSep 12, 2013
  16. TvangesteSep 12, 2013
  17. Torsten BögershausenSep 12, 2013
  18. Junio C HamanoSep 12, 2013
  19. Johannes SixtSep 12, 2013
  20. Junio C HamanoSep 12, 2013
  21. Jiang XinSep 13, 2013
  22. Junio C HamanoSep 13, 2013
  23. Jiang XinSep 17, 2013
  24. 1/3 test: use unambigous leading path (/foo) for mingwJiang Xin, Sep 17, 2013
  25. 2/3 relative_path should honor DOS and UNC pathsJiang Xin, Sep 17, 2013
  26. Junio C HamanoSep 17, 2013
  27. Jiang XinSep 18, 2013
  28. Junio C HamanoSep 18, 2013
  29. 3/3 Use simpler relative_path when set_git_dirJiang Xin, Sep 17, 2013
  30. Johannes SixtSep 17, 2013
  31. Torsten BögershausenSep 18, 2013
  32. Jiang XinSep 20, 2013
  33. 0/3 relative path regression fixJiang Xin, Sep 20, 2013
  34. 1/3 test: use unambigous leading path (/foo) for mingwJiang Xin, Sep 20, 2013
  35. Sebastian SchuberthOct 10, 2013
  36. Jiang XinOct 14, 2013
  37. 0/3 relative path regression fixJiang Xin, Oct 14, 2013
  38. 1/3 test: use unambigous leading path (/foo) for MSYSJiang Xin, Oct 14, 2013
  39. Sebastian SchuberthOct 14, 2013
  40. Eric SunshineOct 14, 2013
  41. 2/3 relative_path should honor dos-drive-prefixJiang Xin, Oct 14, 2013
  42. 3/3 Use simpler relative_path when set_git_dirJiang Xin, Oct 14, 2013
  43. 2/3 relative_path should honor dos-driver-prefixJiang Xin, Sep 20, 2013
  44. Sebastian SchuberthOct 10, 2013
  45. 3/3 Use simpler relative_path when set_git_dirJiang Xin, Sep 20, 2013
  46. Torsten BögershausenSep 13, 2013
  47. Karsten BleesSep 12, 2013
  48. Torsten BögershausenSep 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.