Re: Regression in e02ca72: git svn rebase is broken on Windows

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 10, 2013, 17:06 UTC
Message-ID: <xmqq38pczjw6.fsf@gitster.dls.corp.google.com>
In-Reply-To: <17231378818848@web5m.yandex.ru>

Tvangeste <i.4m.l33t@yandex.ru> writes:

Show 27 quoted lines

> Hi,
>
> After bisecting this problem I ended up with the mentioned commit that completely breaks git-svn for me on Windows (mingw/msys version).
>
> ==========
> #> git svn rebase
> warning: unable to access '': Invalid argument
> warning: unable to access '': Invalid argument
> fatal: unable to access '../../../../w:/work/my/repo.git/.git/config': Invalid argument
> fatal: index file open failed: Invalid argument
> Cannot rebase: You have unstaged changes.
> Please commit or stash them.
> rebase refs/remotes/trunk: command returned error: 1
> ==========
>
> Please note that I use the official git repository as-is, this one (no additional patches):
> git://git.kernel.org/pub/scm/git/git.git
>
> e02ca72f70ed8f0268a81f72cb3230c72e538e77 is the first bad commit
> commit e02ca72f70ed8f0268a81f72cb3230c72e538e77
> Author: Jiang Xin
> Date:   Tue Jun 25 23:53:43 2013 +0800
>
>     path.c: refactor relative_path(), not only strip prefix
>
> Thanks,
>   --Tvangeste

The suspect commit and symptom look consistent. You started from a directory whose absolute path is "w:/work/..." and the updated code mistakenly thoguht that something that begins with "w" (not '/') is not an absolute, so added a series of ../ to make it relative, or something silly like that.

Jiang?