git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 10/15] refs.c: allow multiple reflog updates during a single transaction

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 23, 2014, 18:54 UTC
Message-ID
<xmqq4muusjkc.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1413919462-3458-11-git-send-email-sahlberg@google.com>
Ronnie Sahlberg <sahlberg@google.com> writes:
Show 6 quoted lines
> @@ -3531,7 +3537,7 @@ struct ref_update {
>  	enum transaction_update_type update_type;
>  	unsigned char new_sha1[20];
>  	unsigned char old_sha1[20];
> -	int flags; /* REF_NODEREF? */
> +	int flags; /* REF_NODEREF? or private flags */

Not a very informative comment, I'd have to say. How are users of this API expected to avoid stepping on each others' and API implementation's toes?

Show 6 quoted lines
> @@ -3539,8 +3545,9 @@ struct ref_update {
>  
>  	/* used by reflog updates */
>  	int reflog_fd;
> -	struct lock_file reflog_lock;
> +	struct lock_file *reflog_lock;
What is this change about?

Does the lifetime rule for "struct lock_file" described in Documentation/technical/api-lockfile.txt, namely, "once you call hold_lock_file_* family on it, you cannot free it yourself", have any implication on this?

> +	if (!(update->flags & UPDATE_REFLOG_NOLOCK))
> +		update->reflog_lock = xcalloc(1, sizeof(struct lock_file));
> +

Hmph, does this mean that the caller needs to keep track of the refs it ever touched inside a single transaction, call this without nolock on the first invocation on a particular ref and with nolock on the subsequent invocation?

Or is the "caller" just implementation detail of the API and higher level callers do not have to care?

Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 22 of 28 in “ref-transactions-reflog”
  1. 00/15 ref-transactions-reflogRonnie Sahlberg, Oct 21, 2014
  2. 01/15 refs.c make ref_transaction_create a wrapper to ref_transaction_updateRonnie Sahlberg, Oct 21, 2014
  3. Junio C HamanoOct 23, 2014
  4. Ronnie SahlbergOct 23, 2014
  5. Junio C HamanoOct 23, 2014
  6. Junio C HamanoOct 28, 2014
  7. 02/15 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateRonnie Sahlberg, Oct 21, 2014
  8. Junio C HamanoOct 23, 2014
  9. 03/15 refs.c: rename the transaction functionsRonnie Sahlberg, Oct 21, 2014
  10. 04/15 refs.c: add a new update_type field to ref_updateRonnie Sahlberg, Oct 21, 2014
  11. Junio C HamanoOct 23, 2014
  12. 05/15 refs.c: add a function to append a reflog entry to a fdRonnie Sahlberg, Oct 21, 2014
  13. 06/15 copy.c: make copy_fd preserve meaningful errnoRonnie Sahlberg, Oct 21, 2014
  14. Junio C HamanoOct 23, 2014
  15. Ronnie SahlbergOct 23, 2014
  16. 07/15 refs.c: add a transaction function to append a reflog entryRonnie Sahlberg, Oct 21, 2014
  17. 08/15 refs.c: add a flag to allow reflog updates to truncate the logRonnie Sahlberg, Oct 21, 2014
  18. 09/15 refs.c: only write reflog update if msg is non-NULLRonnie Sahlberg, Oct 21, 2014
  19. Junio C HamanoOct 23, 2014
  20. Ronnie SahlbergOct 28, 2014
  21. 10/15 refs.c: allow multiple reflog updates during a single transactionRonnie Sahlberg, Oct 21, 2014
  22. Junio C HamanoOct 23, 2014
  23. Ronnie SahlbergOct 28, 2014
  24. 11/15 reflog.c: use a reflog transaction when writing during expireRonnie Sahlberg, Oct 21, 2014
  25. 12/15 refs.c: rename log_ref_setup to create_reflogRonnie Sahlberg, Oct 21, 2014
  26. 13/15 refs.c: make unlock_ref/close_ref/commit_ref staticRonnie Sahlberg, Oct 21, 2014
  27. 14/15 refs.c: remove lock_any_ref_for_updateRonnie Sahlberg, Oct 21, 2014
  28. 15/15 refs.c: allow deleting refs with a broken sha1Ronnie Sahlberg, Oct 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.