git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: reword --author error message

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 15, 2015, 17:48 UTC
Message-ID
<xmqq4mrs7x5h.fsf@gitster.dls.corp.google.com>
In-Reply-To
<84cf10a22858275d6e213311c93df7f6a5408f60.1421331608.git.git@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
Show 6 quoted lines
> If an --author argument is specified but does not contain a '>' then git tries
> to find the argument within the exiting authors; and gives the error
> message "No existing author found with '%s'" if there is no match.
>
> This is confusing for users who try to specify a valid complete author
> name.

I suspect that you meant s/a valid/an invalid/, as if it is valid, it cannot not contain '>' (after all, '>' is merely a rough approximation to check if it is "Name <email>" format).

> Rename the error message to make it clearer that the failure has two
> reasons in this case:
> "Bad --author parameter '%s': neither completely wellformed nor part of
> an existing one"

You are trying to help a user who thought "Who www.where.com" was a valid thing to pass to --author; "it is not completely wellformed" is not very helpful without making her realize what in that bogus string is not "completely well-formed".

Perhaps
  "--author '%s' is not 'Name <email>' and no existing author matches that string"
or somesuch?
Previous: Michael J GruberNext: Jeff King
Message 9 of 21 in “commit --amend --author error”
  1. Gunnar WagnerJan 13, 2015
  2. Michael J GruberJan 13, 2015
  3. Jeff KingJan 14, 2015
  4. Michael J GruberJan 15, 2015
  5. commit: reword --author error messageMichael J Gruber, Jan 15, 2015
  6. Michael J GruberJan 15, 2015
  7. Jeff KingJan 15, 2015
  8. Michael J GruberJan 15, 2015
  9. Junio C HamanoJan 15, 2015
  10. Jeff KingJan 16, 2015
  11. Junio C HamanoJan 16, 2015
  12. Philip OakleyJan 16, 2015
  13. Junio C HamanoJan 16, 2015
  14. Eric SunshineJan 16, 2015
  15. Junio C HamanoJan 16, 2015
  16. [PATCHv2] commit: reword --author error messageMichael J Gruber, Jan 26, 2015
  17. Jeff KingJan 26, 2015
  18. Junio C HamanoJan 27, 2015
  19. Jeff KingJan 27, 2015
  20. Philip OakleyJan 27, 2015
  21. Ramsay JonesJan 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.