git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2] commit: reword --author error message

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Jan 27, 2015, 12:22 UTC
Message-ID
<54C782EC.3020309@ramsay1.demon.co.uk>
In-Reply-To
<20150126190711.GA13582@peff.net>
On 26/01/15 19:07, Jeff King wrote:
Show 25 quoted lines
> On Mon, Jan 26, 2015 at 04:48:33PM +0100, Michael J Gruber wrote:
> 
>> -	die(_("No existing author found with '%s'"), name);
>> +	die(_("--author '%s': neither 'Name <email>' nor a match for an existing author"), name);
> 
> I had to add to the bikeshed, but I had to read this several times to
> make sense of it. It is grammatically:
> 
>   X [is] neither Y nor Z
> 
> except that by eliding the verb ("is"), I somehow had trouble making
> sense of Z ("a match...") as a noun.
> 
> I came up with:
> 
>   --author '%s': neither 'Name <email>' nor matches an existing author
> 
> only to see that it was suggested earlier in the thread as a predecessor
> to this. ;)
> 
> I wonder if adding back in the missing verb, rather than a colon, would
> also make more sense:
> 
>   --author '%s' is neither 'Name <email>' nor a match for an existing author
> 
I usually don't like to add anything to the bikeshed, but ...
This sounds odd to me, so maybe:
  --author '%s' is neither in the form of 'Name <email>' nor a match for an existing author
although that is getting a bit long! :-D

ATB, Ramsay Jones

Previous: Philip Oakley
Message 21 of 21 in “commit --amend --author error”
  1. Gunnar WagnerJan 13, 2015
  2. Michael J GruberJan 13, 2015
  3. Jeff KingJan 14, 2015
  4. Michael J GruberJan 15, 2015
  5. commit: reword --author error messageMichael J Gruber, Jan 15, 2015
  6. Michael J GruberJan 15, 2015
  7. Jeff KingJan 15, 2015
  8. Michael J GruberJan 15, 2015
  9. Junio C HamanoJan 15, 2015
  10. Jeff KingJan 16, 2015
  11. Junio C HamanoJan 16, 2015
  12. Philip OakleyJan 16, 2015
  13. Junio C HamanoJan 16, 2015
  14. Eric SunshineJan 16, 2015
  15. Junio C HamanoJan 16, 2015
  16. [PATCHv2] commit: reword --author error messageMichael J Gruber, Jan 26, 2015
  17. Jeff KingJan 26, 2015
  18. Junio C HamanoJan 27, 2015
  19. Jeff KingJan 27, 2015
  20. Philip OakleyJan 27, 2015
  21. Ramsay JonesJan 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.