git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Fix file locking with retry and timeout on Windows

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 5, 2015, 19:57 UTC
Message-ID
<xmqq4mmmrkrq.fsf@gitster.dls.corp.google.com>
In-Reply-To
<cover.1433532967.git.j6t@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
> The remaining 3 patches replace the select() invocation that waits
> for a short time period by the version with poll() that we already
> use in help.c. This is necessary because a select() call where all
> three sets of file descriptors are empty is not supported on Windows.
Thanks.

The use of both select() and poll() in our code has been bugging me for a long time (but wasn't irritating enough to make me do anything about it).

Show 12 quoted lines
>
> Johannes Sixt (4):
>   lockfile: replace random() by rand()
>   help.c: wrap wait-only poll() invocation in sleep_millisec()
>   lockfile: convert retry timeout computations to millisecond
>   lockfile: wait using sleep_millisec() instead of select()
>
>  cache.h    |  1 +
>  help.c     |  2 +-
>  lockfile.c | 31 +++++++++----------------------
>  wrapper.c  |  5 +++++
>  4 files changed, 16 insertions(+), 23 deletions(-)
Previous: Johannes SixtNext: Michael Haggerty
Message 7 of 12 in “lockfile: replace random() by rand()”
  1. lockfile: replace random() by rand()Johannes Sixt, May 30, 2015
  2. Junio C HamanoMay 30, 2015
  3. Johannes SixtJun 4, 2015
  4. Michael HaggertyJun 4, 2015
  5. Junio C HamanoJun 4, 2015
  6. 0/4 Fix file locking with retry and timeout on WindowsJohannes Sixt, Jun 5, 2015
  7. Junio C HamanoJun 5, 2015
  8. Michael HaggertyJun 5, 2015
  9. 1/4 lockfile: replace random() by rand()Johannes Sixt, Jun 5, 2015
  10. 2/4 help.c: wrap wait-only poll() invocation in sleep_millisec()Johannes Sixt, Jun 5, 2015
  11. 3/4 lockfile: convert retry timeout computations to millisecondJohannes Sixt, Jun 5, 2015
  12. 4/4 lockfile: wait using sleep_millisec() instead of select()Johannes Sixt, Jun 5, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.