git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv9 4/4] pathspec: allow querying for attributes

From
Junio C Hamano <gitster@pobox.com>
Date
May 20, 2016, 18:31 UTC
Message-ID
<xmqq4m9seg3y.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAGZ79kZOmo6hh_trBJ_H5QRWgAxbP4JUu_KBUKeeKL1XsAwiOQ@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
> I checked and it looks wrong. the "exclude" section is indented below
> the new attr section
> ...
> I can resend with your proposed fixes as well.

If you do so, please make sure that the way tests check for error condition are consistent. I personally do not think it adds any value to grep for "fatal", but I do not mind if you adjusted them to go the same test_i18ngrep route if you think it does (and if you agree that grepping is not necessary, please do not forget to update the tests you had that use test_i18ngrep).

Thanks.
Previous: Stefan Beller
Message 9 of 9 in “[PATCHv9 0/4] pathspec magic extension to search for attributes”
  1. Stefan BellerMay 19, 2016
  2. 1/4 Documentation: fix a typoStefan Beller, May 19, 2016
  3. 2/4 pathspec: move long magic parsing out of prefix_pathspecStefan Beller, May 19, 2016
  4. 3/4 pathspec: move prefix check out of the inner loopStefan Beller, May 19, 2016
  5. 4/4 pathspec: allow querying for attributesStefan Beller, May 19, 2016
  6. Junio C HamanoMay 19, 2016
  7. Junio C HamanoMay 20, 2016
  8. Stefan BellerMay 20, 2016
  9. Junio C HamanoMay 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.