From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 20 May 2016 18:31:13 GMT
Subject: Re: [PATCHv9 4/4] pathspec: allow querying for attributes
Message-ID: <xmqq4m9seg3y.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZOmo6hh_trBJ_H5QRWgAxbP4JUu_KBUKeeKL1XsAwiOQ@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> I checked and it looks wrong. the "exclude" section is indented below
> the new attr section
> ...
> I can resend with your proposed fixes as well.

If you do so, please make sure that the way tests check for error
condition are consistent.  I personally do not think it adds any
value to grep for "fatal", but I do not mind if you adjusted them to
go the same test_i18ngrep route if you think it does (and if you
agree that grepping is not necessary, please do not forget to update
the tests you had that use test_i18ngrep).

Thanks.