Re: [PATCH v4 0/3] diff-highlight: add support for --graph option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 29, 2016, 21:37 UTC
- Message-ID
- <xmqq4m638ded.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160829173347.454-1-henderson.bj@gmail.com>
Brian Henderson <henderson.bj@gmail.com> writes:
> How does this look? > > Drawing the graph helped me a lot in figuring out what I was > actually testing. thanks!
Yeah, I also am pleased to see the picture of what is being tested in the test script.
With your sign-off, they would have been almost perfect ;-).
Show 13 quoted lines
> Brian Henderson (3): > diff-highlight: add some tests. > diff-highlight: add failing test for handling --graph output. > diff-highlight: add support for --graph output. > > contrib/diff-highlight/Makefile | 5 + > contrib/diff-highlight/diff-highlight | 19 +- > contrib/diff-highlight/t/Makefile | 22 +++ > contrib/diff-highlight/t/t9400-diff-highlight.sh | 223 +++++++++++++++++++++++ > 4 files changed, 263 insertions(+), 6 deletions(-) > create mode 100644 contrib/diff-highlight/Makefile > create mode 100644 contrib/diff-highlight/t/Makefile > create mode 100755 contrib/diff-highlight/t/t9400-diff-highlight.sh