Re: [PATCH v4 0/3] diff-highlight: add support for --graph option

From: Jeff King <peff@peff.net>
Date: Aug 30, 2016, 08:11 UTC
Message-ID: <20160830081152.rbvwexqqe6jwkue2@sigill.intra.peff.net>
In-Reply-To: <20160829173347.454-1-henderson.bj@gmail.com>

On Mon, Aug 29, 2016 at 10:33:44AM -0700, Brian Henderson wrote:

Show 8 quoted lines

> How does this look?
> 
> Drawing the graph helped me a lot in figuring out what I was actually testing. thanks!
> 
> Brian Henderson (3):
>   diff-highlight: add some tests.
>   diff-highlight: add failing test for handling --graph output.
>   diff-highlight: add support for --graph output.

These all look good to me. As Junio mentioned, you need to add a signoff (see the section "Sign your work" in Documentation/SubmittingPatches).

Also, a minor nit, but we don't usually put a "." at the end of our commit message subjects (not worth a re-roll on its own, but if you are sending them again anyway...).

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.