Re: [PATCH v4 4/4] add: modify already added files when --chmod is given

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 14, 2016, 21:54 UTC
Message-ID: <xmqq4m5iqh99.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160914210747.15485-5-t.gummerer@gmail.com>

Thomas Gummerer <t.gummerer@gmail.com> writes:

Show 10 quoted lines

> When the chmod option was added to git add, it was hooked up to the diff
> machinery, meaning that it only works when the version in the index
> differs from the version on disk.
>
> As the option was supposed to mirror the chmod option in update-index,
> which always changes the mode in the index, regardless of the status of
> the file, make sure the option behaves the same way in git add.
>
> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
> ---

This change essentially reverts most of what 4e55ed32 ("add: add --chmod=+x / --chmod=-x options", 2016-05-31) did, except that it keeps the command line option and adjusts its validation, and adds a separate phase to "fix-up" the executable bits for all paths that match the given pathspec, whether they were new or modified or unchanged.

The patch makes sense to me.  Thanks.