[PATCH v4 2/4] update-index: add test for chmod flags
- From
Thomas Gummerer <t.gummerer@gmail.com>
- Date
- Sep 14, 2016, 21:07 UTC
- Message-ID
- <20160914210747.15485-3-t.gummerer@gmail.com>
- In-Reply-To
- <20160914210747.15485-1-t.gummerer@gmail.com>
Currently there is no test checking the expected behaviour when multiple chmod flags with different arguments are passed. As argument handling is not in line with other git commands it's easy to miss and accidentally change the current behaviour.
While there, fix the argument type of chmod_path, which takes an int, but had a char passed in.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com> --- builtin/update-index.c | 2 +- t/t2107-update-index-basic.sh | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/builtin/update-index.c b/builtin/update-index.c index ba04b19..bbdf0d9 100644 --- a/builtin/update-index.c +++ b/builtin/update-index.c @@ -419,7 +419,7 @@ static int add_cacheinfo(unsigned int mode, const unsigned char *sha1, return 0; } -static void chmod_path(int flip, const char *path) +static void chmod_path(char flip, const char *path) { int pos; struct cache_entry *ce; diff --git a/t/t2107-update-index-basic.sh b/t/t2107-update-index-basic.sh index dfe02f4..32ac6e0 100755 --- a/t/t2107-update-index-basic.sh +++ b/t/t2107-update-index-basic.sh @@ -80,4 +80,17 @@ test_expect_success '.lock files cleaned up' ' ) ' +test_expect_success '--chmod=+x and chmod=-x in the same argument list' ' + >A && + >B && + git add A B && + git update-index --chmod=+x A --chmod=-x B && + cat >expect <<-\EOF && + 100755 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0 A + 100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0 B + EOF + git ls-files --stage A B >actual && + test_cmp expect actual +' + test_done
-- 2.10.0.304.gf2ff484